Skip to contentSkip to conversation

Change in openvpn[master]: manpage: fix HTML format for --local

Openvpn-devel In review its_Giaan (Code Review) 2 participants 6 messages Mar 27, 2025 – Apr 4, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1743087987000.I8d981a66932a5424ed959b12ee0cdddf881de91e@...2715...

#1 lore raw

Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/922?usp=email

to review the following change.

Change subject: manpage: fix HTML format for --local
......................................................................

manpage: fix HTML format for --local

Fix the HTML format for --local directive
to match the manpage structure.

Change-Id I8d981a66932a5424ed959b12ee0cdddf881de91e

---
M doc/man-sections/link-options.rst

1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/22/922/1

doc/man-sections/link-options.rst +7 -1
index 287473e..8334d16 100644
@@ -106,7 +106,13 @@
   is not reliable. It is recommended to set tun-mtu with enough headroom
   instead.
 
---local host|* [port] [protocol]
+--local args
+
+  Valid syntax:
+  ::
+
+     local host|* [port] [protocol]
+
   Local host name or IP address and port for bind. If specified, OpenVPN will bind
   to this address. If unspecified, OpenVPN will bind to all interfaces.
   '*' can be used as hostname and means 'any host' (OpenVPN will listen on what

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/922?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8d981a66932a5424ed959b12ee0cdddf881de91e
Gerrit-Change-Number: 922
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, its_Giaan, plaisthos.

mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/922?usp=email )

Change subject: manpage: fix HTML format for --local
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
This fixes the formatting issue based on my tests.

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/922?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8d981a66932a5424ed959b12ee0cdddf881de91e
Gerrit-Change-Number: 922
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: mattock <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: its_Giaan <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Thu, 27 Mar 2025 16:04:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 manpage: fix HTML format for --local

In reply to a message not in the archive

From: Gianmarco De Gregori <[email protected]...>

Fix the HTML format for --local directive
to match the manpage structure.

Change-Id I8d981a66932a5424ed959b12ee0cdddf881de91e

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/922
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Samuli Seppänen <[email protected]...>

doc/man-sections/link-options.rst +7 -1
index 287473e..8334d16 100644
@@ -106,7 +106,13 @@
   is not reliable. It is recommended to set tun-mtu with enough headroom
   instead.
 
---local host|* [port] [protocol]
+--local args
+
+  Valid syntax:
+  ::
+
+     local host|* [port] [protocol]
+
   Local host name or IP address and port for bind. If specified, OpenVPN will bind
   to this address. If unspecified, OpenVPN will bind to all interfaces.
   '*' can be used as hostname and means 'any host' (OpenVPN will listen on what
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: manpage: fix HTML format for --local

This is documentation only, no code to test - to the untrained eye, the change looks good, and Samuli confirmed that the HTML created is correct now. In it goes :-)

Your patch has been applied to the master branch.

commit a51fb119d7e9a9db9173a10f9e20a4035ca76bbe

Author: Gianmarco De Gregori
Date:   Wed Apr 2 16:08:51 2025 +0200
     manpage: fix HTML format for --local

     Signed-off-by: Gianmarco De Gregori <[email protected]...>
     Acked-by: Samuli Seppänen <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg31321.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/922?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by mattock

Change subject: manpage: fix HTML format for --local
......................................................................

manpage: fix HTML format for --local

Fix the HTML format for --local directive
to match the manpage structure.

Change-Id I8d981a66932a5424ed959b12ee0cdddf881de91e

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31321.html

---
M doc/man-sections/link-options.rst

1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/22/922/2

doc/man-sections/link-options.rst +7 -1
index 287473e..8334d16 100644
@@ -106,7 +106,13 @@
   is not reliable. It is recommended to set tun-mtu with enough headroom
   instead.
 
---local host|* [port] [protocol]
+--local args
+
+  Valid syntax:
+  ::
+
+     local host|* [port] [protocol]
+
   Local host name or IP address and port for bind. If specified, OpenVPN will bind
   to this address. If unspecified, OpenVPN will bind to all interfaces.
   '*' can be used as hostname and means 'any host' (OpenVPN will listen on what

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/922?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8d981a66932a5424ed959b12ee0cdddf881de91e
Gerrit-Change-Number: 922
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: mattock <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/922?usp=email )

Change subject: manpage: fix HTML format for --local
......................................................................

manpage: fix HTML format for --local

Fix the HTML format for --local directive
to match the manpage structure.

Change-Id I8d981a66932a5424ed959b12ee0cdddf881de91e

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31321.html

---
M doc/man-sections/link-options.rst

1 file changed, 7 insertions(+), 1 deletion(-)
doc/man-sections/link-options.rst +7 -1
index 287473e..8334d16 100644
@@ -106,7 +106,13 @@
   is not reliable. It is recommended to set tun-mtu with enough headroom
   instead.
 
---local host|* [port] [protocol]
+--local args
+
+  Valid syntax:
+  ::
+
+     local host|* [port] [protocol]
+
   Local host name or IP address and port for bind. If specified, OpenVPN will bind
   to this address. If unspecified, OpenVPN will bind to all interfaces.
   '*' can be used as hostname and means 'any host' (OpenVPN will listen on what

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/922?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8d981a66932a5424ed959b12ee0cdddf881de91e
Gerrit-Change-Number: 922
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: mattock <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged